Skip to content

test(cache): keep the backend's early answer to an upload in the e2e proxy #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wan9chi merged 1 commit into from
Nov 9, 2026
Merged

test(cache): keep the backend's early answer to an upload in the e2e proxy #985

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/tools/src/remote-cache/daemon.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,8 @@ function pass(
);
upstream.on('error', (error) => {
// The Worker rejects an upload by its headers, answering before it reads
// the body, and then closes the connection, so sending the rest fails.
// the body, and then closes the connection, which can reset it after the
// answer.
if (clientGone || backendReply?.complete) return;
anomalies.push(`${label} failed: ${error.message}`);
if (response.headersSent) response.destroy();
Expand All @@ -159,7 +160,13 @@ function pass(
clientGone = true;
upstream.destroy();
});
request.pipe(upstream);
// Send the body once it has all arrived, so it goes out with the headers
// before the Worker can answer. Sending part of it after a rejection fails
// if the connection was reset, and that can lose the answer before it's
// read.
const body: Buffer[] = [];
request.on('data', (chunk: Buffer) => body.push(chunk));
request.on('end', () => upstream.end(Buffer.concat(body)));
}

const control = createServer((request, response) => {
Expand Down
Loading