Repository navigation
test(run): fix the order of remote requests in unknown_after_remote_hit - #986
Merged
wan9chi merged 1 commit intoNov 9, 2026
Merged
Conversation
`dry_run_json::unknown_after_remote_hit` failed on main's macOS CI and on #984's Windows job. Its first step ran `vt run after-emit`, which runs `emit` first. Once `emit` finishes, its upload starts in the background at the same time as `after-emit`'s fetch, and the e2e proxy logs each request when its response finishes. So the backend log read `fetch, store, fetch, store` as often as the expected `fetch, fetch, store, store`. `VP_RUN_INTERNAL_HIDE_PENDING_UPLOADS` hides the upload's progress, but doesn't delay it. Each dependency now runs in its own step first: `vt run emit`, then `vt run after-emit`, and `vt run build` before `vt run after-build`. Each step then makes at most one fetch followed by one upload. The dry runs that the case checks are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fspy benchmarklinuxmacoswindows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
dry_run_json::unknown_after_remote_hit, added in #968, is flaky. It failed on main's macOS CI (job), on #969's, and on #984's Windows job (run). In its first step, the backend log readfetch 404, store 200, fetch 404, store 200instead offetch 404, fetch 404, store 200, store 200.Changes
vt run after-emitrunsemitfirst. Onceemitfinishes, its upload starts in the background at the same time asafter-emit's fetch, and the e2e proxy logs each request when its response finishes, so either can come first.VP_RUN_INTERNAL_HIDE_PENDING_UPLOADShides the upload's progress, but doesn't delay it.vt run emitbeforevt run after-emit, andvt run buildbeforevt run after-build. Each step then makes at most one fetch followed by one upload, in a fixed order.after-emitis stillunknownafter a remote hit that restores outputs, andafter-buildis still a hit.🤖 Generated with Claude Code
Note
Low Risk
Test fixture and snapshot updates only; no production run or remote-cache logic changes.
Overview
Fixes flaky
unknown_after_remote_hitdry-run e2e snapshots by splitting combined runs into separate steps:vt run emitbeforevt run after-emit, andvt run buildbeforevt run after-build.That keeps each remote-cache interaction to a deterministic fetch-then-store order (uploads from the first task no longer overlap the dependent task’s fetch when the proxy logs responses). Comments and the
unknown_after_remote_hit.mdsnapshot were updated for the extra steps, cache-hit replay lines, and corrected expectations (e.g.after-buildas full cache hit with no fetch).snapshots.tomland the markdown snapshot are the only touched files; asserted dry-run behavior is unchanged.Reviewed by Cursor Bugbot for commit 9226b86. Bugbot is set up for automated code reviews on this repo. Configure here.