Repository navigation
docs: annotate getPrerenderPaths() return types - #727
Merged
cpojer merged 1 commit intoNov 6, 2026
Merged
Conversation
Void does not infer the return type from the page filename, so the guides show a PageParams annotation. Co-authored-by: Cursor <cursoragent@cursor.com>
Member
|
Nice one! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#726 brought up the issue of typesafety for
getPrerenderPaths. It fixes runtime issues, but the issue can be caught even earlier with proper type annotations forgetPrerenderPaths(). I think we should encourage this practice.PageParamsreturn annotation forgetPrerenderPaths()on dynamic pages, since Void does not infer it from the filename.Promise<string[]>.Test plan
Made with Cursor