Repository navigation
fix(client): require explicit methods for non-GET requests - #734
Open
niteshseram wants to merge 1 commit into
Open
niteshseram wants to merge 1 commit into
niteshseram wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The typed fetch client accepts calls to POST-only routes without a method. These calls pass typechecking but send GET, so the POST handler never runs.
For a route that only exports POST, both calls previously compiled:
Both send GET. The POST type argument only affects TypeScript; it does not set the request method.
Cause
The fetch types made
methodoptional for every request and allowed calls without options even when the route had no GET handler.Fix
Require an explicit method for non-GET requests. The calls above now produce a missing-method error, while the correct call continues to work:
Also clarify the requirement in the typed fetch documentation.