Skip to content

fix(react): derive form state from submission outcomes and guard concurrent submits #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kotarotaniguchi0523 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(react): derive form state from submission outcomes and guard concurrent submits #738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 11 additions & 16 deletions packages/react/src/runtime/form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {
useEffect,
useState,
useCallback,
type FormEvent,
type FormHTMLAttributes,
type ReactElement,
type ReactNode,
Expand All @@ -9,7 +9,6 @@ import {
formErrorMessage,
formRetryMessage,
formSubmissionBlocked,
scheduleFormRetry,
type FormModel,
type FormMethod,
type VoidActionError,
Expand All @@ -31,22 +30,18 @@ export function Form({
children,
...props
}: FormProps): ReactElement {
const [now, setNow] = useState(Date.now);
useEffect(() => scheduleFormRetry(form.error, () => setNow(Date.now())), [form.error]);
const message = formErrorMessage(form);
const retry = formRetryMessage(form.error);
const blocked = formSubmissionBlocked(form, now);
const onSubmit = useCallback(
(event: FormEvent<HTMLFormElement>) => {
if (formSubmissionBlocked(form)) {
event.preventDefault();
}
},
[form],
);
return (
<form
{...props}
action={form[method]}
aria-busy={form.pending}
onSubmit={(event) => {
if (blocked) {
event.preventDefault();
}
}}
>
<form {...props} action={form[method]} aria-busy={form.pending} onSubmit={onSubmit}>
{message && (
<div role="alert" data-void-form-error>
{form.error && renderError ? renderError(form.error) : message}
Expand Down
Loading