Skip to content

upgrade golangci-lint to v2.15.0 - #509

Open
acsoto wants to merge 3 commits into
volcano-sh:mainfrom
acsoto:build/upgrade-golangci-lint
Open

acsoto wants to merge 3 commits into
volcano-sh:mainfrom
acsoto:build/upgrade-golangci-lint

Conversation

@acsoto

@acsoto acsoto commented Nov 9, 2026

Copy link
Copy Markdown
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Upgrade golangci-lint from v1.64.1 to v2.15.0. CI and local development both use make lint to check Go formatting, validate the v2 configuration, and run the linters.

Which issue(s) this PR fixes:

None.

Special notes for your reviewer:

The Router migrates to ReverseProxy.Rewrite and uses Go's query sanitization. Tests cover forwarding headers, hop-by-hop removal, authorization, and encoded query values. The mTLS configuration disables session tickets so new connections recheck the current trust bundle.

Local lint and Go unit tests passed. The Router forwarding regression test passed at the final head.

Does this PR introduce a user-facing change?:

The Router now drops query parameters that Go cannot parse when forwarding requests to sandboxes. AgentCube mTLS connections use a full handshake on reconnect.

Signed-off-by: Zhou Zihang <z@mcac.cc>
Signed-off-by: Zhou Zihang <z@mcac.cc>
Signed-off-by: Zhou Zihang <z@mcac.cc>
@volcano-sh-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from acsoto. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 86.48649% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.00%. Comparing base (f521ae9) to head (b3be6ec).
⚠️ Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
pkg/router/auth.go 33.33% 4 Missing ⚠️
pkg/picod/server.go 0.00% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #509      +/-   ##
==========================================
+ Coverage   60.45%   64.00%   +3.55%     
==========================================
  Files          35       35              
  Lines        3616     3656      +40     
==========================================
+ Hits         2186     2340     +154     
+ Misses       1211     1086     -125     
- Partials      219      230      +11     
Flag Coverage Δ
unittests 64.00% <86.48%> (+3.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants