fix(langchain): support separator-containing store keys - #4335
Open
Mchenr wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support slash- and backslash-containing LangGraph store keys without sending encoded path separators that OpenViking rejects.
The adapter keeps each BaseStore key as exactly one URI segment. It first applies the existing percent encoding, then translates encoded separators into adapter-level escape tokens:
Because
quote(..., safe="")encodes a literal!as%21before!sand!bare introduced, separator escapes remain distinct from literal marker text. Keys without separators retain their existing URI layout.This preserves LangGraph's
(namespace, key)boundary: namespace labels remain URI hierarchy, while the complete opaque key remains the final segment.Human Involvement
Related Issue
Fixes #4334
Type of Change
Changes Made
/as!sand\as!bafter percent encoding.!s/!b.Testing
Validation performed:
72 passedintests/unit/test_langchain_integration.pylangchain_openvikingsource filesgit diff --check/AGENTS.mdand literal!sAGENTS.mdremain separate records through write/read/list/glob/searchChecklist
Additional Notes
This revision adopts the single-segment encoding suggested in the issue discussion. It avoids changing namespace semantics or introducing an internal URI hierarchy.