Repository navigation
Fix demodulation opposite literal case - #1055
Merged
Merged
Conversation
quickbeam123
approved these changes
Nov 10, 2026
MichaelRawson
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix, we wrongly returned the inverse of the result when comparing literals that are the exact opposites of each other. This optimization is apparently not triggered very often, the fix did not give any difference on TPTP FOL.
When trying to write a test for it in demodulation, I realized we use a different check there which is also wrong (overly restrictive, so we might lose demodulations with
drc=ordering).