Repository navigation
Conversation
MichaelRawson
approved these changes
Nov 12, 2026
| .filter([](Literal* lit){ return lit->isEquality(); }) | ||
| .flatMap([](Literal* lit) { | ||
| return pvi(pushPairIntoRightIterator(lit, getUniquePersistentIterator<TermListHash, TermListHash2>(vi(new BooleanSubtermIt(lit))))); | ||
| return pvi(pushPairIntoRightIterator(lit, getUniquePersistentIterator<TermListHash, TermListHash2>(vi(new BooleanSubtermIterator(lit))))); |
Contributor
There was a problem hiding this comment.
Ooh, existing error but maybe this inner vi can be skipped as getUniquePersistentIterator takes a template?
| _stack.push(t.term()); | ||
| } | ||
| } | ||
| auto [lhs, rhs] = static_cast<Literal*>(term)->eqArgs(); |
Contributor
There was a problem hiding this comment.
Because this is only used by HOL, and in HOL all literals are equations?
Collaborator
There was a problem hiding this comment.
I vaguely remember that the phantom-sh type guards of Sledgehammer remain as non-eq literals (but of course only in TH1), something like well_ordering(\alpha)...
| { | ||
| public: | ||
| BooleanSubtermIt(Term* term, bool includeSelf=false) | ||
| BooleanSubtermIterator(Term* term, bool = false) |
Collaborator
There was a problem hiding this comment.
Does this bool = false mean that the second argument has no purpose, but you don't want to change the interface?
quickbeam123
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another remnant of the HOL branch, with a bit of improvement. It allows going into lambdas for (subsumption) demodulation. This would also yield terms that contain loose DB indices, for (subsumption) demodulation these are useless, so we simply avoid yielding them. Not binding terms with loose DB indices is handled by the indexing structures.
Results are not amazing, but show some improvement.
HOL TPTP Discount:
run 0 unsat: 2139 (7) sat: 1 (0) cputime: 10401.23 s instructions: 49437748 Mi memory: 241412.25 MB
run 1 unsat: 2146 (14) sat: 1 (0) cputime: 10349.94 s instructions: 49286501 Mi memory: 237456.11 MB
HOL TPTP Otter:
run 0 unsat: 2121 (9) sat: 1 (0) cputime: 10696.50 s instructions: 49874264 Mi memory: 341942.55 MB
run 1 unsat: 2127 (15) sat: 1 (0) cputime: 10637.84 s instructions: 49721435 Mi memory: 335902.12 MB