Skip to content

Device info should include make and model #19

Description

@brianpeiris

getVRDevices returns device information that is not very useful:

HMDVRDevice { hardwareUnitId: "uknownHMDInfo-0x18545800", deviceId: "somedevid", deviceName: "HMD Device" } 
PositionSensorVRDevice { hardwareUnitId: "uknownHMDInfo-0x18545800", deviceId: "somedevid", deviceName: "HMD Position Device" }

The Chromium implementation actually returns "Oculus Rift DK2" as the deviceName.

This information (e.g. DK1 vs DK2) is useful when we need to account for different resolutions and optical warp factors.

Although, ideally I suppose we'd be sniffing for capabilities instead of particular devices in accordance to the web's best practices. Right now my application is guessing whether the user is in a DK1 based solely on window resolution when in fullscreen.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions