Skip to content

Deprecate and remove closure based condition analysis. - #285

Draft
garretrieger wants to merge 3 commits into
w3c:mainfrom
garretrieger:remove_closure_condition_analysis
Draft

garretrieger wants to merge 3 commits into
w3c:mainfrom
garretrieger:remove_closure_condition_analysis

Conversation

@garretrieger

Copy link
Copy Markdown
Contributor

Removes all code related to supporting closure based condition analysis (and related unmapped glyph handling). Dep graph based condition analysis is much faster and more accurate due to it's ability to find composite conditions, so there isn't really a need to keep these around anymore.

Concretely removes condition analysis modes:

  • CLOSURE_ONLY
  • CLOSURE_AND_DEP_GRAPH
  • CLOSURE_AND_VALIDATE_DEP_GRAPH
    With DEP_GRAPH_ONLY and DEP_GRAPH_ONLY_WITH_SIMPLIFICATION retained.

and unmapped glyph handling modes:
PATCH
MOVE_TO_INIT_FONT

Removes all code related to supporting closure baesd condition analysis (and related unmapped glyph handling). Dep graph based condition analysis is much faster and more accurate due to it's ability to find composite conditions, so there isn't really a need to keep these around anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant