Repository navigation
Deprecate and remove closure based condition analysis. - #285
Draft
garretrieger wants to merge 3 commits into
Draft
garretrieger wants to merge 3 commits into
garretrieger wants to merge 3 commits into
Conversation
Removes all code related to supporting closure baesd condition analysis (and related unmapped glyph handling). Dep graph based condition analysis is much faster and more accurate due to it's ability to find composite conditions, so there isn't really a need to keep these around anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes all code related to supporting closure based condition analysis (and related unmapped glyph handling). Dep graph based condition analysis is much faster and more accurate due to it's ability to find composite conditions, so there isn't really a need to keep these around anymore.
Concretely removes condition analysis modes:
CLOSURE_ONLYCLOSURE_AND_DEP_GRAPHCLOSURE_AND_VALIDATE_DEP_GRAPHWith DEP_GRAPH_ONLY and DEP_GRAPH_ONLY_WITH_SIMPLIFICATION retained.
and unmapped glyph handling modes:
PATCHMOVE_TO_INIT_FONT