Skip to content

Prompt for rider weight wherever W/kg would render as 0 - #44

Merged
walkersutton merged 1 commit into
mainfrom
feat/rider-weight-prompts
Sep 30, 2026
Merged

walkersutton merged 1 commit into
mainfrom
feat/rider-weight-prompts

Conversation

@walkersutton

Copy link
Copy Markdown
Owner

Summary

With no rider weight set, every power_to_weight readout renders 0.0, which is easy to miss until after an export. This surfaces the weight input wherever that happens:

  • Preview canvas — floating banner over the preview when the template uses W/kg (floats so the preview doesn't shift when it appears/disappears)
  • Element properties — inline prompt under the metric picker for value / meter / gauge elements set to W/kg
  • Element list — warning icon on W/kg rows while no weight is set
  • Export dialog — prompt before rendering; Enter inside the field edits rather than starting the render
  • Settings — weight input extracted into a reusable RiderWeightField

State: appState gains usesRiderWeight / needsRiderWeight getters; riderWeightKg resolution is shared.

Also removes the "C" logo chip from the top toolbar.

Test plan

  • Load a template with a W/kg element and no rider weight → banner on canvas, warning icon in element list, prompt in properties
  • Enter a weight in any of the prompts → all prompts disappear, readouts show real values
  • Open export dialog with no weight → prompt shown; pressing Enter in the field doesn't start the render
  • Switch kg/lb → value converts correctly

🤖 Generated with Claude Code

Adds a shared RiderWeightField (Settings) and RiderWeightPrompt, shown in
the export dialog, the preview canvas, and W/kg element properties when the
template uses power_to_weight but no weight is set. Element list flags
affected W/kg rows with a warning icon.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
cyclemetry Ready Ready Preview Sep 30, 2026 4:13am UTC

Request Review

@walkersutton
walkersutton merged commit 803415e into main Sep 30, 2026
3 checks passed
@walkersutton
walkersutton deleted the feat/rider-weight-prompts branch September 30, 2026 04:14

This branch was successfully deployed

1 active deployment
Preview — e872de69 Deployed Sep 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant