fix: capture PR URL before composing Slack notification message#318
fix: capture PR URL before composing Slack notification message#318dannyneira wants to merge 3 commits into
Conversation
The previous SKILL.md snippet had the pr_url capture line commented out, so the agent would hit a NameError when composing the Slack message body. - Uncomment and activate the subprocess call to gh pr view --json url - Add subprocess to imports - Remove stale Grafana token reference from workflow comment Co-Authored-By: Oz <oz-agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR updates the release_updates skill Slack notification snippet to capture the just-created PR URL before composing the Slack message, and refreshes the release docs workflow comment to reference the Slack bot token requirement.
Concerns
- No blocking correctness, security, or spec-alignment concerns found in the annotated diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
|
||
| # Installs the stable oz CLI and runs the release_updates skill in the | ||
| # release-docs Oz environment (K5KStCm5aYvhfBJb8cHol6), which has | ||
| # DOCS_AGENT_GRAFANA_TOKEN configured for on-call reviewer assignment. |
There was a problem hiding this comment.
Did we mean to remove the comment about the grafana token?
There was a problem hiding this comment.
yup, no longer using the DOCS_AGENT_GRAFANA_TOKEN anymore in this automation.
I'm justing using the slack @oncall-client-primary/secondary since they already setup to notify the right people
There was a problem hiding this comment.
Using a docs bot slack token now to send the messages to #oncall-client :)
If the release run is a no-op (no docs changes), gh pr view exits non-zero and CalledProcessError would crash the snippet. Now we catch that and exit cleanly with a log message. Co-Authored-By: Oz <oz-agent@warp.dev>
2 participants
Summary
The Slack notification snippet in
SKILL.mdhad thepr_urlcapture line commented out, so when the Oz agent ran the code,pr_urlwas undefined — causing the Slack message to be sent without the PR link (or failing with aNameError).Changes
.agents/skills/release_updates/SKILL.md: Uncomment and activate thesubprocesscall togh pr view --json url --jq .urlsopr_urlis always populated before the Slack message is composed. Addedsubprocessto imports..github/workflows/release-docs-update.yml: Remove stale comment referencingDOCS_AGENT_GRAFANA_TOKEN(removed in fix: replace on-call reviewer assignment with Slack notification + last-reviewer #307); replace with accurate note aboutDOCS_SLACK_BOT_TOKEN.Testing
Triggered by the previous failed run where the Slack message posted without a PR URL. This fix ensures the Slack message always includes the PR link.
Co-Authored-By: Oz oz-agent@warp.dev