Repository navigation
1.0.1 changes - #1
Merged
Merged
Conversation
waysnx-tech
approved these changes
Sep 22, 2026
waysnx-tech
left a comment
waysnx-tech
left a comment
Contributor
There was a problem hiding this comment.
Reviewed for 1.0.1 release. CI checks and release configuration verified.
14 tasks
krantighatpande
added a commit
that referenced
this pull request
Oct 30, 2026
…losure button only - Remove redundant navigation landmarks in Sidebar and Navbar wrappers - Sidebar: Changed outer nav wrapper to div, pass ariaLabel to Menu - Navbar: Removed role='navigation' from mobile menu wrapper, pass ariaLabel to Menu - MenuItem: Remove aria-expanded from anchor tag (items with href+children) - aria-expanded now only on disclosure/chevron button as required - Add regression tests for navigation landmarks and aria-expanded placement - Update existing tests to check chevron button instead of anchor - All 89 tests passing, TypeScript clean, build successful Addresses final review feedback for Phase 3 P0 #1 Keyboard Accessibility
krantighatpande
added a commit
that referenced
this pull request
Oct 30, 2026
…losure button only Final corrections for Phase 3 P0 #1 review feedback: - Remove redundant nav landmarks in Sidebar and Navbar - Keep aria-expanded only on disclosure button, not anchor - Add regression tests for both corrections - All 89 tests passing
krantighatpande
added a commit
that referenced
this pull request
Oct 30, 2026
Final review corrections for Phase 3 P0 #1 Keyboard Accessibility: - Remove incomplete arrow key handlers (Arrow keys, Home, End) from Menu component - MenuItem no longer uses focused state for tabIndex, so handlers prevented default without moving focus - Native Tab/Shift+Tab navigation is sufficient per W3C Disclosure Navigation Pattern - Add deprecated 'role' prop for backwards API compatibility (Menu always renders as <nav>) - Add :focus-visible styles for disclosure buttons to ensure visible focus indicators - Add regression tests for focus indicators on all interactive elements - Update arrow key tests to reflect handler removal - All 89 tests passing, TypeScript clean, build successful Addresses final review feedback items 1, 2, and 3 for PR #10
krantighatpande
added a commit
that referenced
this pull request
Oct 30, 2026
Final corrections for Phase 3 P0 #1 Keyboard Accessibility: - Align Menu forwardRef type with rendered <nav> element (HTMLElement not HTMLDivElement) - Update menuRef type from HTMLDivElement to HTMLElement - Remove @ts-expect-error from deprecated role prop test (TypeScript correctly accepts the prop) - All 89 tests passing, TypeScript clean, build successful Addresses final review feedback for PR #10
krantighatpande
added a commit
that referenced
this pull request
Oct 30, 2026
Consistency fix for Phase 3 P0 #1 Keyboard Accessibility: - Navbar: Change forwardRef from HTMLDivElement to HTMLElement (renders <nav>) - Sidebar: Change forwardRef from HTMLDivElement to HTMLElement (renders <aside>) - Update useRef types to match forwardRef types - Ensures all components in this PR have correctly aligned ref types - All 89 tests passing, TypeScript clean, build successful Maintains consistency with Menu component forwardRef type alignment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type
Validation
Documentation