chore(deps): react and react-dom to 19.3.0, together - #5
Merged
Merged
Conversation
Dependabot proposed these as two pull requests -- `react` in one,
`react-dom` in the other. React refuses to run when the two disagree:
Error: Incompatible React versions: the "react" and "react-dom" packages
must have the exact same version.
so each pull request failed six frontend suites on its own, and neither could
ever go green alone. They are the same upgrade and land as one commit, with
`@types/react` and `@types/react-dom` moved to match.
The entry chunk grew 29,273 B on this upgrade alone -- 214,558 to 243,831 --
with no source change, which put it over the 220,000 B budget.
The structural half of `check-bundle.mjs` was checked first, because that is
the failure the budget exists to catch: all six page groups are still separate
chunks, so nothing leaked into the shell and the growth really is React.
The budget moves to 260,000. The comment beside it argued against exactly that
number, and was right to at the time: it assumed an un-split build weighed
about 240 kB. The check derives that figure from the build rather than
remembering it, and it is now 301,858 B, so 260,000 sits 42 kB below the point
where this check would stop being able to tell a split build from an un-split
one. The comment is rewritten rather than left contradicting the constant.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
API Verity — contract reviewOne comment per PR — updated on each push. |
This was referenced Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #2 and #3.
Dependabot proposed these as two pull requests —
reactin one,react-domin the other. React refuses to run when the two disagree (Incompatible React versions: the "react" and "react-dom" packages must have the exact same version), so each failed six frontend suites on its own and neither could go green alone. They are the same upgrade and land as one commit, with the@types/*packages moved to match.On the bundle budget. The entry chunk grew 29,273 B on this upgrade alone (214,558 → 243,831) with no source change, breaching the 220,000 B budget.
I checked the structural assertion first, because that is the failure the budget exists to catch: all six page groups are still separate chunks, so nothing leaked into the shell and the growth really is React.
The budget moves to 260,000. The comment beside it argued against exactly that number and was right to at the time — it assumed an un-split build weighed ~240 kB. The check derives that figure from the build rather than remembering it, and it is now 301,858 B, so 260,000 sits 42 kB below the point where this check would stop distinguishing a split build from an un-split one. The comment is rewritten rather than left contradicting the constant.