fix(schema): stop double-emitting foreign keys in Schema::create() - #65
Merged
Merged
Conversation
Schema::create() compiled every $table->foreign() twice: once inlined as a column-level CONSTRAINT by compileCreate(), and again as a separate ALTER TABLE ... ADD CONSTRAINT via compileForeignKeys() — no grammar suppresses the second pass. MySQL rejects the duplicate constraint (errno 121) and SQLite rejects the statement outright (ALTER TABLE ADD CONSTRAINT isn't valid SQLite DDL), so any table defined with foreign() could never be created via Schema::create() on either driver. Fix: drop the redundant compileForeignKeys() pass from Schema::create() — the constraints are already present from compileCreate(). This does not affect Schema::table(), which still needs compileForeignKeys() to add constraints to already-existing tables. Adds tests/Integration/SchemaForeignKeyTest.php, reproduced and verified fixed against real MySQL (errno 121) and SQLite (syntax error) connections; full unit + integration suites pass on both drivers. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Schema::create() compiled every $table->foreign() twice: once inlined as a column-level CONSTRAINT by compileCreate(), and again as a separate ALTER TABLE ... ADD CONSTRAINT via compileForeignKeys() — no grammar suppresses the second pass. MySQL rejects the duplicate constraint (errno 121) and SQLite rejects the statement outright (ALTER TABLE ADD CONSTRAINT isn't valid SQLite DDL), so any table defined with foreign() could never be created via Schema::create() on either driver.
Fix: drop the redundant compileForeignKeys() pass from Schema::create() — the constraints are already present from compileCreate(). This does not affect Schema::table(), which still needs compileForeignKeys() to add constraints to already-existing tables.
Adds tests/Integration/SchemaForeignKeyTest.php, reproduced and verified fixed against real MySQL (errno 121) and SQLite (syntax error) connections; full unit + integration suites pass on both drivers.