Repository navigation
chore: bump kextract (b27b562) and regenerate WebGPU bindings - #133
Merged
Merged
Conversation
Advance the kextract submodule from 07d57be to master b27b562, which includes klang-toolkit/kextract#63 (large 64-bit headers) and klang-toolkit/kextract#64 (Android callGeneric fallback). Regenerated bindings: - wgpu_hJvm.kt: JVM struct-layout registration split into per-struct helper functions (kextract #63, 64 KiB method limit) + whitespace. - wgpu_hNative.kt: whitespace only. - wgpu_hAndroid.kt: generic-path downcalls now scope their argument allocator in try/finally, drop the unused void return buffer, and read unsigned scalar returns through converted carriers (kextract #64) + whitespace (kextract #63). - wgpu_hCommon.kt: unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Bump the
kextractsubmodule from07d57beto masterb27b562— which now includes klang-toolkit/kextract#63 (large 64-bit headers) and klang-toolkit/kextract#64 (AndroidcallGenericfallback for shapes outside the kffi Android baseline) — and regenerate the versioned multiplatform WebGPU bindings.Changes
kextractsubmodule:07d57be→b27b562(master).wgpu_hJvm.kt,wgpu_hNative.kt,wgpu_hAndroid.kt;wgpu_hCommon.ktis unchanged.wgpu_hJvm.kt: struct-layout registration split into per-struct helper functions (__kffiJvmStructFieldsN_0()/__kffiJvmRegisterStructLayoutN()) to stay under the JVM 64 KiB method limit (kextract Bump com.charleskorn.kaml:kaml from 0.76.0 to 0.77.0 #63), plus whitespace.wgpu_hNative.kt: whitespace only.wgpu_hAndroid.kt: the 44 generic-path downcalls now scope their argument allocator intry { … } finally { argsAllocator.close() }, void returns no longer allocate an unused output buffer (0Lpassed instead), and unsigned scalar generic returns are read through converted carriers (.toUInt(),.toULong(), …) — kextract wgpuInstanceRequestAdapter crash on MacOS X64 #64. Fixed-shape wrapper selection is unchanged: every shape used bywebgpu.his inside the kffi Android engine baseline.No build-script change: the existing sanitized-header generator input already provides a fixed 64-bit
size_t, so--allow-64-bit-scalarsis not required.Validation
./gradlew :wgpu4k-native:generateBindingsFromHeader→ BUILD SUCCESSFUL./gradlew :wgpu4k-native:compileKotlinJvm :wgpu4k-native:compileDebugKotlinAndroid --rerun-tasks→ BUILD SUCCESSFUL (fresh compile, no cache)./gradlew :wgpu4k-native:verifyGeneratedBindingsClean→ BUILD SUCCESSFUL./gradlew :wgpu4k-native:verifyJvmBootstrapBinding→ BUILD SUCCESSFUL./gradlew :wgpu4k-native:verifyBindingGenerationConfiguration→ BUILD SUCCESSFULNotes
verifyGeneratedBindingsCleanrequires committed files to match the generator output exactly.callGenericfunctions change (allocator lifetime, void out-buffer removal); no fixed-shape call changes; the allowlist addition and unsigned-return conversion have no additional effect onwebgpu.hbeyond those 44 functions.