Repository navigation
Conversation
srish
requested changes
Oct 6, 2026
srish
left a comment
srish
left a comment
Member
There was a problem hiding this comment.
@jhsoby Thanks for adding these!
One blocker: the oki entry in language-data.json is missing the autonym and has a trailing comma. Also, it should come after oka as it does in langdb.yaml. This is probably also why the build is failing.
Could you regenerate the file with php src/util/ulsdata2json.php and push the result?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phabricator tasks: