Skip to content

Don't lower key in setEditProperty + remove canproperty check #3666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Astralcircle merged 2 commits into from
Jul 22, 2026
Merged

Don't lower key in setEditProperty + remove canproperty check #3666

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c88197
Don't lower key in setEditProperty
Astralcircle Jul 21, 2026
1c677bc
Remove canproperty check
Astralcircle Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions lua/entities/gmod_wire_expression2/core/entity.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,9 +159,7 @@ e2function number entity:setEditProperty(string key, string value)
if not IsValid(this) then return self:throw("Invalid entity!", 0) end
if not isOwner(self, this) then return self:throw("You do not own this entity!", 0) end
if not this.Editable then return self:throw("Tried to edit non-editable entity!", 0) end
if not canProperty(self.player, this, "editentity") then return self:throw("Gamemode disallowed editing this entity!", 0) end

key = key:lower()
local edit = this:GetEditingData()[key]
if not edit then return self:throw("Property '" .. key .. "' does not exist on entity!", 0) end
if not canEditVariable(this, self.player, key, value, edit) then return self:throw("Server disallowed editing this property!", 0) end
Expand Down
Loading