Skip to content

Dataset map assumes that self.data is an iterator and supports assignment. #7

Description

@HesitantlyHuman

I suggest that the map function should iterate over self, so that the index function is used instead. That way if index needs to be overloaded, map, may not need to be.

The same applies for the assignment, I suggest implementing some sort of set_index function, which can be overloaded.
That way, handling the overhead of map is not necessary for most special cases.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

bugSomething isn't workingenhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions