Repository navigation
ci: ignore zizmor's unpinned-uses and artipacked findings on the Pullfrog workflow - #63
Merged
Merged
Conversation
…frog workflow pullfrog.yml is generated by the Pullfrog app and reached main without a pull request, so the workflow audit never ran on it, and every pull request to main now fails "Audit workflows" on a file it did not touch. The file is the app's to change, so zizmor ignores, for that file only, the two audits it fails today: unpinned-uses (actions/checkout@v6 and pullfrog/pullfrog@v0) and artipacked (the checkout keeps its credentials). Every other audit still runs on it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J22sD4rHr39R1HMKd8G7hn
|
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
Reviewed the zizmor config change that stops unpinned-uses and artipacked from failing CI on the generated Pullfrog workflow.
- File-scoped ignores —
.github/zizmor.ymlignorespullfrog.ymlfor those two rules only. Other audits still cover that file, and both rules still cover every other workflow. Re-ranzizmor==1.30.1on.github/: exit 0, 3 ignored.
grok-4.7 | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
.github/workflows/pullfrog.ymlis generated by the Pullfrog app and reachedmainwithout a pull request, so the workflow audit never ran on it. Every pull request tomainnow fails "Audit workflows" on that file, which none of them touch. The file is the app's to change, so zizmor ignores, for that file only, the two audits it fails today:rules: dependabot-cooldown: … unpinned-uses: config: policies: … + ignore: + # Generated by the Pullfrog app, not edited here. + - pullfrog.yml + artipacked: + ignore: + # Generated by the Pullfrog app, not edited here. + - pullfrog.ymlEvery other audit still runs on
pullfrog.yml, and these two still run on every other workflow. No workflow changes.Evidence
The audit's own command,
pipx run --spec zizmor==1.30.1 zizmor --format=github .github/, run in a clone:main): exit 14. It reports three findings, all onpullfrog.yml, the ones that fail "Audit workflows" on every pull request tomaintoday:run: echo "${{ inputs.prompt }}"appended topullfrog.ymlis still flagged (template-injection). A checkout like the app's inworkflow-audit.yml(actions/checkout@v7, nopersist-credentials: false) still fails bothunpinned-usesandartipacked.Merge Danger
Door: two-way. Reverting these lines puts the audit back as it is on
main.Blast Radius: CI. Only zizmor reads this file. If the app ever adds another unpinned action or checkout to
pullfrog.yml, these two audits won't flag it there.🤖 Generated with Claude Code
https://claude.ai/code/session_01J22sD4rHr39R1HMKd8G7hn