Skip to content

chore: remove theme-toggle from the Index - #13

Merged
rqbazan merged 3 commits into
mainfrom
chore/remove-theme-toggle
Oct 24, 2026
Merged

rqbazan merged 3 commits into
mainfrom
chore/remove-theme-toggle

Conversation

@rqbazan

@rqbazan rqbazan commented Oct 24, 2026

Copy link
Copy Markdown
Member

Summary

The Keeper keeps only the most relevant Projects in the Index, and theme-toggle isn't one of them. It leaves the Index, and its Project page and og:image go with it. theme-toggle's repository, its npm package and the design canvas stay as they are.

 src/content/
 ├── index.yaml              # projects: run-run, vland, env
-│                           #           …, theme-toggle
 └── projects/
     ├── env.yaml
     ├── run-run.yaml
-    ├── theme-toggle.yaml
     └── vland.yaml

The file goes too, not just its entry: getIndex() fails the build when a Project isn't listed in the Index.

The docs describe the three-Project site:

  • add-a-project.md step 1 holds the reason: being published isn't enough, because the Keeper keeps only the most relevant Projects in the Index. theme-toggle joins portless and gh-actions in its list of what stays out. content.md, content-model.md and design.md link to it.
  • content.md loses theme-toggle's section. content-model.md quotes env's Tagline and vland's Closing line as its examples.
  • design.md says the canvas still draws theme-toggle and the site builds none of it. Rule 3's table shows the three Projects' Also indexed. The rules that cited theme-toggle (Install command width, Published as, the Package break, the og:image name size, the ogSnippet names) stay general, without its examples.

/theme-toggle now returns a 404 like any unknown path, with no redirect.

This changes design.md without an issue first, which contributing.md asks for. The Keeper asked for this change directly.

Evidence

  • Before: astro build generated 12 routes, including /og/theme-toggle.png and /theme-toggle.html.
    After:
    /apple-touch-icon.png  /favicon.svg
    /og/run-run.png  /og/vland.png  /og/env.png  /og.png
    /run-run.html  /vland.html  /env.html  /index.html
    
    grep -r theme-toggle dist/ finds nothing.
  • Served by wrangler dev, as the Worker serves dist/:
    200 /   200 /run-run   200 /vland   200 /env   200 /og.png
    404 /theme-toggle   404 /theme-toggle/   404 /theme-toggle.html
    404 /og/theme-toggle.png   404 /nope
    
  • In the browser at 1280, 834 and 390px:
    • The Index lists run-run and vland under Apps, and env under Libraries.
    • Also indexed shows run-run → vland, env; vland → run-run, env; env → run-run, vland.
    • No page scrolls horizontally.
    • Every Tagline and Install command fits on one line.
    • Copy copies the Command and announces Copied.
    • Focus is visible.
  • The og:images: every Project's name renders at 84px, and the Index's panel now holds the whole Index.
  • rr check and astro build pass.

Merge Danger

Door: two-way

Reverting the PR puts theme-toggle back: its content is in git history.

Blast Radius: one-URL

lab.variable.land/theme-toggle and /og/theme-toggle.png return 404 once this deploys. That breaks the link on theme-toggle's README title, and any shared link to the page loses its preview image. Both are accepted.

🤖 Generated with Claude Code

https://claude.ai/code/session_016PWAkM8oTRgBQz9NDGR3e5

rqbazan and others added 3 commits October 24, 2026 16:15
The Keeper keeps only the most relevant Projects in the Index, and
theme-toggle isn't one of them. Its Project page and og:image go with
it, so /theme-toggle returns a 404 like any unknown path. The docs
describe the three-Project site and say why theme-toggle stays out.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016PWAkM8oTRgBQz9NDGR3e5
… design notes

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016PWAkM8oTRgBQz9NDGR3e5
@changeset-bot

changeset-bot Bot commented Oct 24, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 5b35107

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cloudflare-workers-and-pages

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://chore-remove-theme-toggle-variablelab-www.raquirozbazan.workers.dev (commit 5b35107)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://53870651-variablelab-www.raquirozbazan.workers.dev 5b35107 2026-10-24T21:23:36.514Z Visit the dashboard ↗

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

Reviewed the removal of theme-toggle from the Index, its Project page, and its og:image, and the docs that now describe a three-Project site.

  • Index membership — theme-toggle leaves src/content/index.yaml, and src/content/projects/theme-toggle.yaml is deleted. That matches getIndex(): a Project file that is not listed fails the build.
  • Routes — Project pages and og:images are built from getIndex(), so /theme-toggle and /og/theme-toggle.png are not emitted. wrangler.jsonc has no not-found handling, so those paths 404 with no redirect, as the PR states.
  • Also indexed — rule 3's table matches alsoIndexed() for the remaining order: same Class first, then the other Class, in Index order. env now lists run-run, vland because theme-toggle was the only other Library.
  • Examples — the tagline, closing line, file-name, and schema error examples no longer cite theme-toggle. The replacements match env and vland as written in content.md. The kebab-case regexes are unchanged.
  • Spec — add-a-project.md, content-model.md, content.md, and design.md record that the Keeper keeps only the most relevant Projects, and that the canvas still draws theme-toggle while the site builds none of it. No other tracked file still names it.

Pullfrog  | View workflow run | Using grok-4.7 | 𝕏

@rqbazan
rqbazan merged commit 58d45b4 into main Oct 24, 2026
7 checks passed
@rqbazan
rqbazan deleted the chore/remove-theme-toggle branch October 24, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant