Repository navigation
chore: remove theme-toggle from the Index - #13
Merged
Merged
Conversation
The Keeper keeps only the most relevant Projects in the Index, and theme-toggle isn't one of them. Its Project page and og:image go with it, so /theme-toggle returns a 404 like any unknown path. The docs describe the three-Project site and say why theme-toggle stays out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016PWAkM8oTRgBQz9NDGR3e5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016PWAkM8oTRgBQz9NDGR3e5
… design notes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016PWAkM8oTRgBQz9NDGR3e5
|
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://chore-remove-theme-toggle-variablelab-www.raquirozbazan.workers.dev (commit 5b35107)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
Reviewed the removal of theme-toggle from the Index, its Project page, and its og:image, and the docs that now describe a three-Project site.
- Index membership —
theme-toggleleavessrc/content/index.yaml, andsrc/content/projects/theme-toggle.yamlis deleted. That matchesgetIndex(): a Project file that is not listed fails the build. - Routes — Project pages and
og:images are built fromgetIndex(), so/theme-toggleand/og/theme-toggle.pngare not emitted.wrangler.jsonchas no not-found handling, so those paths 404 with no redirect, as the PR states. - Also indexed — rule 3's table matches
alsoIndexed()for the remaining order: same Class first, then the other Class, in Index order. env now lists run-run, vland because theme-toggle was the only other Library. - Examples — the tagline, closing line, file-name, and schema error examples no longer cite theme-toggle. The replacements match env and vland as written in
content.md. The kebab-case regexes are unchanged. - Spec —
add-a-project.md,content-model.md,content.md, anddesign.mdrecord that the Keeper keeps only the most relevant Projects, and that the canvas still draws theme-toggle while the site builds none of it. No other tracked file still names it.
grok-4.7 | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
The Keeper keeps only the most relevant Projects in the Index, and theme-toggle isn't one of them. It leaves the Index, and its Project page and
og:imagego with it. theme-toggle's repository, its npm package and the design canvas stay as they are.The file goes too, not just its entry:
getIndex()fails the build when a Project isn't listed in the Index.The docs describe the three-Project site:
add-a-project.mdstep 1 holds the reason: being published isn't enough, because the Keeper keeps only the most relevant Projects in the Index. theme-toggle joins portless and gh-actions in its list of what stays out.content.md,content-model.mdanddesign.mdlink to it.content.mdloses theme-toggle's section.content-model.mdquotes env's Tagline and vland's Closing line as its examples.design.mdsays the canvas still draws theme-toggle and the site builds none of it. Rule 3's table shows the three Projects' Also indexed. The rules that cited theme-toggle (Install command width, Published as, the Package break, theog:imagename size, theogSnippetnames) stay general, without its examples./theme-togglenow returns a 404 like any unknown path, with no redirect.This changes design.md without an issue first, which
contributing.mdasks for. The Keeper asked for this change directly.Evidence
astro buildgenerated 12 routes, including/og/theme-toggle.pngand/theme-toggle.html.After:
grep -r theme-toggle dist/finds nothing.wrangler dev, as the Worker servesdist/:Copied.og:images: every Project's name renders at 84px, and the Index's panel now holds the whole Index.rr checkandastro buildpass.Merge Danger
Door: two-way
Reverting the PR puts theme-toggle back: its content is in git history.
Blast Radius: one-URL
lab.variable.land/theme-toggleand/og/theme-toggle.pngreturn 404 once this deploys. That breaks the link on theme-toggle's README title, and any shared link to the page loses its preview image. Both are accepted.🤖 Generated with Claude Code
https://claude.ai/code/session_016PWAkM8oTRgBQz9NDGR3e5