Skip to content

Add SHTC3_v2 usermod to platformio.ini - #5756

Open
Will-wastelander wants to merge 2 commits into
wled:mainfrom
Will-wastelander:patch-1
Open

Add SHTC3_v2 usermod to platformio.ini#5756
Will-wastelander wants to merge 2 commits into
wled:mainfrom
Will-wastelander:patch-1

Conversation

@Will-wastelander

@Will-wastelander Will-wastelander commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Add SHTC3_v2 usermod for temperature sensing.

Summary by CodeRabbit

  • New Features
    • Added support for SHTC3 v2 temperature/humidity sensors to the Waveshare ESP32-S3 Hub75 build.
    • Enables temperature and humidity readings from compatible SHTC3 v2 devices.

Add SHTC3_v2 usermod for temperature sensing.
@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: fdd39218-9b1c-498f-bc33-4bfb40c0c6ae

📥 Commits

Reviewing files that changed from the base of the PR and between e39e1ab and 4812bb0.

📒 Files selected for processing (1)
  • platformio.ini
🚧 Files skipped from review as they are similar to previous changes (1)
  • platformio.ini

Walkthrough

The Waveshare ESP32-S3 32MB HUB75 build environment adds the SHTC3_v2 usermod repository to its existing custom usermod list.

Changes

SHTC3 usermod integration

Layer / File(s) Summary
Add SHTC3_v2 to build environment
platformio.ini
The waveshare_esp32s3_32MB_hub75 environment now includes the SHTC3_v2 Git repository in custom_usermods.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely states the main change: adding the SHTC3_v2 usermod to platformio.ini.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
platformio.ini (1)

1168-1168: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick win

Pin the SHTC3_v2 dependency to an immutable commit.

The new external usermod tracks the repository’s moving default branch, so future builds may silently consume different code. Pin it to a commit SHA, consistent with the nearby audioreactive dependency.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@platformio.ini` at line 1168, Update the SHTC3_v2 dependency declaration to
reference a specific immutable commit SHA instead of the repository’s moving
default branch, following the nearby audioreactive dependency’s pinning format.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@platformio.ini`:
- Line 1168: Update the SHTC3_v2 dependency declaration to reference a specific
immutable commit SHA instead of the repository’s moving default branch,
following the nearby audioreactive dependency’s pinning format.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 3ca38a03-d879-4669-b14d-9d652194e67a

📥 Commits

Reviewing files that changed from the base of the PR and between 8db3d7a and e39e1ab.

📒 Files selected for processing (1)
  • platformio.ini

Updated SHTC3_v2 usermod URL to specific commit.

@Will-wastelander Will-wastelander left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated waveshare_esp32s3_32MB_hub75 build env to include SHTC3 UM, enabling the onboard temp/hum sensor.

Comment thread platformio.ini
custom_usermods =
Internal_Temperature
audioreactive = https://github.com/MoonModules/WLED-AudioReactive-Usermod#8d988e985901e00a0a92e119aaa8e3249f817754 ;; SR_DMTYPE 254 fix
SHTC3_v2 = https://github.com/lost-hope/SHTC3_v2/commit/b8a648e7b71ac1bb6efca1bacdf6577aeb17b09c

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lost-hope is this an "official" usermod?

@Will-wastelander

Copy link
Copy Markdown
Contributor Author

@softhack007 They created this UM at my request, in #sensors on discord. I'm not sure if they have released it to WLED-AC yet or not, but I wanted to get this added to the build env, so it would have the support. Here is the link to their post in that channel.
https://discord.com/channels/473448917040758787/708677213830250527/1527357353056534579

@softhack007

softhack007 commented Jul 27, 2026

Copy link
Copy Markdown
Member

@lost-hope I've quickly looked through the UM code.

One line is a bit problematic

https://github.com/lost-hope/SHTC3_v2/blob/b8a648e7b71ac1bb6efca1bacdf6577aeb17b09c/SHTC3_v2.cpp#L134

this delay() runs in the main loop, it can lead to effect stuttering for higher framerates, especially above 60FPS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants