Add SHTC3_v2 usermod to platformio.ini - #5756
Conversation
Add SHTC3_v2 usermod for temperature sensing.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe Waveshare ESP32-S3 32MB HUB75 build environment adds the ChangesSHTC3 usermod integration
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
platformio.ini (1)
1168-1168: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winPin the SHTC3_v2 dependency to an immutable commit.
The new external usermod tracks the repository’s moving default branch, so future builds may silently consume different code. Pin it to a commit SHA, consistent with the nearby
audioreactivedependency.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@platformio.ini` at line 1168, Update the SHTC3_v2 dependency declaration to reference a specific immutable commit SHA instead of the repository’s moving default branch, following the nearby audioreactive dependency’s pinning format.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@platformio.ini`:
- Line 1168: Update the SHTC3_v2 dependency declaration to reference a specific
immutable commit SHA instead of the repository’s moving default branch,
following the nearby audioreactive dependency’s pinning format.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 3ca38a03-d879-4669-b14d-9d652194e67a
📒 Files selected for processing (1)
platformio.ini
Updated SHTC3_v2 usermod URL to specific commit.
Will-wastelander
left a comment
There was a problem hiding this comment.
Updated waveshare_esp32s3_32MB_hub75 build env to include SHTC3 UM, enabling the onboard temp/hum sensor.
| custom_usermods = | ||
| Internal_Temperature | ||
| audioreactive = https://github.com/MoonModules/WLED-AudioReactive-Usermod#8d988e985901e00a0a92e119aaa8e3249f817754 ;; SR_DMTYPE 254 fix | ||
| SHTC3_v2 = https://github.com/lost-hope/SHTC3_v2/commit/b8a648e7b71ac1bb6efca1bacdf6577aeb17b09c |
|
@softhack007 They created this UM at my request, in #sensors on discord. I'm not sure if they have released it to WLED-AC yet or not, but I wanted to get this added to the build env, so it would have the support. Here is the link to their post in that channel. |
|
@lost-hope I've quickly looked through the UM code. One line is a bit problematic this |
Add SHTC3_v2 usermod for temperature sensing.
Summary by CodeRabbit