Conversation
Until now method='robust' was only reachable via --errors, which needs it for the covariance. --robust selects it on its own; --errors still implies it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fitAlphaBeta(method='robust')was previously unreachable from theAlphaBeta.pyCLI:the only path into it was
-e/--errors, which needs the robust fit because it is theonly method that produces a covariance.
-r/--robustso the robust velocity-residual fit can be selected on its own,without asking for the full error estimation.
--errors' help that it always uses the robust fit, and notes in--robust'shelp that
--errorsimplies it.No change to
fitAlphaBeta()itself — CLI wiring only, default behaviour (Q4) unchanged.Test plan
python -m wmpl.Utils.AlphaBeta --helpshows both flags with the corrected help textpython -m wmpl.Utils.AlphaBeta <traj.pickle> -ron a real trajectory pickle gives thesame alpha/beta as
-e(minus the uncertainties)🤖 Generated with [Claude Code]