Fix macOS dyld lib path#443
Open
aidangarske wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the repository’s env-setup helper to correctly configure macOS dynamic library lookup so locally built OpenSSL/wolfSSL/wolfProvider libraries are found reliably during CI and local runs.
Changes:
- Continue reconstructing
LD_LIBRARY_PATHas before for ELF platforms. - Add a parallel export of
DYLD_LIBRARY_PATHfor macOS sodyldcan locate freshly built libraries even when sonames change.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Jenkins retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS the loader honors DYLD_LIBRARY_PATH, not LD_LIBRARY_PATH, but
env-setuponly exported the latter. Tests then relied on rpath alone and broke when OpenSSL bumped its soname (libssl.so.3->libssl.so.4). Export DYLD_LIBRARY_PATH alongside LD_LIBRARY_PATH.Fixes the wolfProvider PRB macOS timeout supervisor issue (
infra:job::wolfProvider/PRB-master-job::timeout), where the macOS branches failed to load the freshly built OpenSSL libs and hung until the parent 2h timeout.Preventative for: https://jenkins-supervisor.wolfssl.com/#/open-issues/511