Repository navigation
fix(authorization): answer a repeated role assignment with the one already held - #210
Open
etiennecoutaud wants to merge 1 commit into
Open
etiennecoutaud wants to merge 1 commit into
etiennecoutaud wants to merge 1 commit into
Conversation
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryRepeated direct role assignments now return the existing assignment with
No actionable issues found. Reviews (1) · Last reviewed commit: "fix(authorization): answer a repeated ro..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /authorization/organization_memberships/:id/role_assignmentsinserted a new assignment on every call, so assigning the same role on the same resource twice stored two assignments, and listing the membership's role assignments returned both.Fixes #208
Behavior
Checked against a WorkOS staging environment:
201201201, the same assignment (sameid)201, a new assignmentThe emulator now matches every row.
What changed
201if one exists.docs/behavior.md: the Native group authorization paragraph notes the repeated direct assignment, next to the409for a duplicate group assignment.No other endpoint changes behavior.
Tests
authorization-checks.spec.ts: the repeat returns the first assignment'sidwith201, the same role on the organization stays a separate assignment, and the list holds two. It fails onmain.bun test(2091 pass),bun run typecheck,bun run lint,bun run fmt:check,bun run build,node scripts/check-package.mjs,node scripts/smoke-node.mjs, and the codegen drift check all pass.