Repository navigation
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
[Medium impact] The PR appears safe to merge. SummaryAdds one-request updates for direct membership role assignments, with checks before any grants change.
No actionable issues found. Reviews (1) · Last reviewed commit: "feat(authorization): support PATCH for m..." · Reviewed by Greptile |
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
Original prompt from Colin
|
Summary
Clients can now add and remove direct membership role assignments in one atomic PATCH against emulate, without falling back to separate POST and DELETE requests. A failed entry leaves all assignments unchanged.
Proof
With a local emulator seeded with a membership and a
viewergrant, I ran:HTTP/1.1 204 No ContentThe response body was empty. GET listed only
viewerbefore and onlyeditorafter.bun test,bun run typecheck,bun run lint,bun run fmt:check, andbun run gen:supportedpassed.The pinned
@workos/openapi-spec@0.160.0omits this operation, so regenerating the support table produced no diff.bun run check:coveragewith the pinned spec still exits nonzero for the same 82 missing operations as main and reports this PATCH as emulator-only.Refs ENT-8219
Link to Devin session: https://workos.devinenterprise.com/sessions/6de12c49e35e45c2a9b60989946dc291
Open in Devin Desktop: https://workos.devinenterprise.com/desktop/session/6de12c49e35e45c2a9b60989946dc291?variant=devin
Requested by: @csrbarber
🟢 Devin Review found nothing to fix · View findings