fix(cli): default dir to auto for create, import, and export - #35
Merged
Conversation
Pick up library dir defaulting and message attribute inheritance from msg #63 and #64 so CLI round-trips match. Refs #33 Co-authored-by: Cursor <cursoragent@cursor.com>
Cover loader fallback attributes and warn signature, missing trgDir import default, and omitting srcDir when dir is auto. Refs #33 Co-authored-by: Cursor <cursoragent@cursor.com>
Align create-project loaders, XLIFF import, and export with the library auto default (Option B: skip srcDir when dir is auto). Refs #33 Co-authored-by: Cursor <cursoragent@cursor.com>
Keep create-project loader samples, import JSON examples, and export srcDir notes consistent with the library. Refs #33 Co-authored-by: Cursor <cursoragent@cursor.com>
jsahleen
marked this pull request as ready for review
August 16, 2026 01:56
|
🎉 This PR is included in version 0.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@worldware/msgto^0.12.0so the CLI uses librarydirdefaulting and message attribute inheritance (msg #63 / #64).create projectloader fallbacks now usedir: 'auto'and warn without dumping the caughterror.dirto"auto"when<file>has notrgDir.srcDirwhendiris"auto"(Option B), and still writesltr/rtl.Closes #33.
Depends on the published
@worldware/msg@0.12.0(msg #63, #64).Test plan
dir: 'auto'and a message-onlyconsole.warntrgDiryieldsdir: 'auto'; explicittrgDirstill winssrcDir="auto"and still emitssrcDir="rtl"/"ltr"npm test,npx tsc --noEmit,npm run build,npm run coverage(lines/statements > 90%)Made with Cursor