Conversation
Empty-string dir currently overrides DEFAULT_ATTRIBUTES.dir, and standalone messages skip defaults entirely. Capture the intended auto default before implementation. Refs #63 Co-authored-by: Cursor <cursoragent@cursor.com>
Spread-merging let dir: '' win over DEFAULT_ATTRIBUTES. Centralize attribute defaults so omitted or empty dir always becomes auto. Refs #63 Co-authored-by: Cursor <cursoragent@cursor.com>
Keep copy-paste samples aligned with the library default so empty string dir does not reappear in new projects. Refs #63 Co-authored-by: Cursor <cursoragent@cursor.com>
jsahleen
marked this pull request as ready for review
August 16, 2026 01:37
|
🎉 This PR is included in version 0.11.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dirto"auto"onMsgResourceandMsgMessageso it matchesDEFAULT_ATTRIBUTESinstead of winning via spread-merge.attributesobject.MsgAttributesdocs so copy-paste samples usedir: 'auto'.Closes #63.
Companion CLI work remains in worldware-studios/msg-cli#33 (loader fallback, import
trgDir ?? "auto", export Option B: omitsrcDirwhendiris"auto").Test plan
dir,dir: '', and explicitltr/rtl/autoon resources and messagesadd({ dir: '' })normalize to"auto"npm test,npx tsc --noEmit,npm run build,npm run coverage(> 90%)Made with Cursor