Skip to content

Fix PHPCS errors in Behat test files - #545

Merged
swissspidy merged 1 commit into
mainfrom
fix/tests-lint
Sep 1, 2026
Merged

swissspidy merged 1 commit into
mainfrom
fix/tests-lint

Conversation

@swissspidy

@swissspidy swissspidy commented Sep 1, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Style
    • Cleaned up indentation and trailing whitespace in plugin-related test scenarios.
    • No user-visible behavior changes.

Copilot AI lite review requested due to automatic review settings September 1, 2026 10:35
@swissspidy
swissspidy requested a review from a team as a code owner September 1, 2026 10:35
@github-actions github-actions Bot added the scope:testing Related to testing label Sep 1, 2026
@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: f256d4e5-32e7-4f05-ab1a-f4fcb92c5ab6

📥 Commits

Reviewing files that changed from the base of the PR and between 0a41471 and 4f78013.

📒 Files selected for processing (3)
  • features/plugin-activate.feature
  • features/plugin-deactivate.feature
  • features/plugin.feature

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The pull request cleans up indentation and trailing whitespace in embedded PHP snippets across three feature fixtures. It does not change behavior or public declarations.

Changes

Feature fixture formatting

Layer / File(s) Summary
Embedded PHP formatting cleanup
features/plugin-activate.feature, features/plugin-deactivate.feature, features/plugin.feature
Embedded PHP callbacks use adjusted indentation and no longer contain specified trailing whitespace. Callback logic remains unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 4f780

This change only corrects formatting in Behat test files without changing test logic or product behavior; no actionable merge-blocking risk remains.

Suggested reviewers: schlessera

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: correcting PHPCS issues in Behat test files. The changes remove trailing whitespace and normalize indentation in those files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/tests-lint

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@swissspidy swissspidy added this to the 3.0.1 milestone Sep 1, 2026
@swissspidy
swissspidy merged commit 7e35f62 into main Sep 1, 2026
57 checks passed
@swissspidy
swissspidy deleted the fix/tests-lint branch September 1, 2026 10:50
@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants