Repository navigation
refactor(cli): remove unused CDN Pulumi helpers that bypassed the shared work dir - #272
Open
stewartjarod wants to merge 1 commit into
Open
stewartjarod wants to merge 1 commit into
stewartjarod wants to merge 1 commit into
Conversation
…red work dir runCdnPulumiProgram, previewCdnStack and destroyCdnStack had no callers. They built the work dir from process.env.HOME and named the project wraps-cdn, both of which the shared helpers (getPulumiWorkDir and the pinned project name) replaced. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GxJAQQr6pNB7qCy8dj9CYR
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes three unused functions from
packages/cli/src/infrastructure/cdn-stack.ts:runCdnPulumiProgram,previewCdnStackanddestroyCdnStack.Nothing called them, and a repo-wide search finds no references in code or docs. They also predate the shared helpers:
process.env.HOME, where everything else usesgetPulumiWorkDir();wraps-cdn, which fix(cli): pin the Pulumi project name and refuse on a mismatch or split #270 replaced with the pinnedwraps-email.If anything started calling them, it would bypass both.
deployCdnStack, the CDN program the commands use, is unchanged.Checks
CI=true: 3704/3704turbo typecheck --filter=@wraps.dev/cli: pass🤖 Generated with Claude Code
https://claude.ai/code/session_01GxJAQQr6pNB7qCy8dj9CYR