Bump hazelcast orbit bundle to 5.3.7.wso2v2 - #4631
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 SummarySummary by CodeRabbit
WalkthroughChangesHazelcast Orbit dependency update
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This updates the Hazelcast Orbit bundle selected for the Hazelcast feature from 5.3.6.wso2v1 to 5.3.7.wso2v2. No current merge-blocking risk is identified. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description explains the purpose and implementation approach, but it omits most required template sections, including User stories, Release note, Documentation, Training, Certification, Marketing, Automation tests, Security checks, Samples, Related PRs, Migrations, Test environment, and Learning. Resolution Complete the missing template sections. Use “N/A” with a brief explanation where a section does not apply. Include test and security-check results, documentation impact, release-note text, related PRs, migration impact, and the test environment.
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🟡 Changes recommended
The updated Hazelcast orbit version is described as not yet released/published, which will cause dependency resolution (and CI) to fail until the artifact becomes available.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the Carbon parent BOM to consume a newer WSO2 Orbit Hazelcast bundle (5.3.7.wso2v2) in order to pick up Hazelcast’s re-shaded Jackson version (2.22.2) that isn’t configurable via an exposed Maven property.
Changes:
- Bump
orbit.version.hazelcastfrom5.3.6.wso2v1to5.3.7.wso2v2inparent/pom.xml.
File summaries
| File | Description |
|---|---|
| parent/pom.xml | Updates the shared Hazelcast orbit version property used by dependency management and features. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
5.3.7.wso2v2 re-shades jackson to 2.22.2 in place of the copy hazelcast embeds, which is not reachable from any pom property. This also moves hazelcast itself 5.3.6 -> 5.3.7. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
0d0a61a to
6d95c51
Compare
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
left a comment
jenkins-is-staging
left a comment
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/34205393556
Purpose
Pick up
hazelcast 5.3.7.wso2v2, which re-shades jackson to 2.22.2 in place of the copy upstreamhazelcast embeds in
com.hazelcast.shaded.com.fasterxml.jackson. That version is not reachable fromany pom property, so the fix is a new orbit bundle rather than a version bump here.
Approach
parent/pom.xml:orbit.version.hazelcast5.3.6.wso2v1→5.3.7.wso2v2.Hazelcast itself moves 5.3.6 → 5.3.7, a patch release. Its embedded dependency set is unchanged from
5.3.6 — everit-json-schema 1.14.3, HikariCP 4.0.3, classgraph 4.8.158, org.json 20231013,
snakeyaml-engine 2.6 — so jackson is the only thing that changes.
5.3.7.wso2v2's OSGi manifest is identical to5.3.7.wso2v1's when both are built with the sametoolchain: 654
Import-Packageand 571Export-Packageentries, same sets, no mandatory imports.Blocked on
wso2/orbit#1408 — needs
5.3.7.wso2v2released to Nexus before this can build. Draft until then.