Skip to content

Bump bouncycastle version to 1.85.0.wso2v1 - #4634

Merged
sadilchamishka merged 1 commit into
wso2:4.12.xfrom
sadilchamishka:bumpBouncycastle185
Sep 21, 2026
Merged

sadilchamishka merged 1 commit into
wso2:4.12.xfrom
sadilchamishka:bumpBouncycastle185

Conversation

@sadilchamishka

@sadilchamishka sadilchamishka commented Sep 21, 2026 •

Copy link
Copy Markdown

Purpose

Move the Bouncy Castle orbit bundles from 1.84.0.wso2v1 to 1.85.0.wso2v1.

Approach

bouncycastle.version in parent/pom.xml drives all four bundles shipped by the
org.wso2.carbon.core.server feature — bcprov, bcpkix, bctls and bcpg — so this is a
single-property change. bcprov, bcpkix and bcpg at 1.85.0.wso2v1 came from wso2/orbit#1402;
the matching bctls bundle is wso2/orbit#1412.

All four are published and resolve from wso2-public.

Copilot AI lite review requested due to automatic review settings September 21, 2026 05:35
@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: wso2/carbon-kernel/.coderabbit.yml

Review profile: CHILL

Plan: Advanced

Run ID: 85b60c88-8df1-43b0-9c4f-5c02ff83640e

📥 Commits

Reviewing files that changed from the base of the PR and between 25cf521 and f383c77.

📒 Files selected for processing (1)
  • parent/pom.xml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated the Bouncy Castle security library version used by the application.

Walkthrough

The parent POM updates the managed Bouncy Castle version from 1.84.0.wso2v1 to 1.85.0.wso2v1. This updates the referenced bcprov-jdk18on, bcpkix-jdk18on, and bctls-jdk18on dependency versions.

Changes

Bouncy Castle dependency update

Layer / File(s) Summary
Update managed dependency version
parent/pom.xml
The bouncycastle.version property changes to 1.85.0.wso2v1. Managed Bouncy Castle dependencies use this property.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: dilshansenarath

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the purpose and implementation, but it omits most required template sections, including Goals, User stories, Release note, Documentation, Training, Certification, Marketing, A… Complete the required template sections. Mark non-applicable sections as N/A with a brief explanation, and provide test, security, release-note, documentation, and migration details where applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the main change: updating the Bouncy Castle version to 1.85.0.wso2v1.
Full details: Description check

Explanation

The description explains the purpose and implementation, but it omits most required template sections, including Goals, User stories, Release note, Documentation, Training, Certification, Marketing, Automation tests, Security checks, Samples, Related PRs, Migrations, Test environment, and Learning.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The PR notes a required orbit artifact (bctls 1.85.0.wso2v1) may not be published yet, which would break dependency resolution/CI for this version bump.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 High severity

Open (1)
What changed in this PR

Updates the parent Maven property that controls the WSO2 Orbit Bouncy Castle bundle versions so the Carbon kernel distribution can consume 1.85.0.wso2v1 artifacts (bcprov/bcpkix/bctls/bcpg).

Changes:

  • Bump bouncycastle.version from 1.84.0.wso2v1 to 1.85.0.wso2v1 in parent/pom.xml.
File Description
parent/​pom.xml Updates the shared Bouncy Castle orbit version property used by dependency management and feature bundle definitions.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread parent/pom.xml
@jenkins-is-staging

Copy link
Copy Markdown

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/35566328651

@jenkins-is-staging

Copy link
Copy Markdown

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/35566328651
Status: failure

@jenkins-is-staging

Copy link
Copy Markdown

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/35611334156

@jenkins-is-staging

Copy link
Copy Markdown

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/35611334156
Status: success

@jenkins-is-staging jenkins-is-staging left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/35611334156

@sadilchamishka
sadilchamishka merged commit 0f64a8e into wso2:4.12.x Sep 21, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants