Bump bouncycastle version to 1.85.0.wso2v1 - #4634
Conversation
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: wso2/carbon-kernel/.coderabbit.yml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe parent POM updates the managed Bouncy Castle version from ChangesBouncy Castle dependency update
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description explains the purpose and implementation, but it omits most required template sections, including Goals, User stories, Release note, Documentation, Training, Certification, Marketing, Automation tests, Security checks, Samples, Related PRs, Migrations, Test environment, and Learning.
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The PR notes a required orbit artifact (bctls 1.85.0.wso2v1) may not be published yet, which would break dependency resolution/CI for this version bump.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
Updates the parent Maven property that controls the WSO2 Orbit Bouncy Castle bundle versions so the Carbon kernel distribution can consume 1.85.0.wso2v1 artifacts (bcprov/bcpkix/bctls/bcpg).
Changes:
- Bump
bouncycastle.versionfrom1.84.0.wso2v1to1.85.0.wso2v1inparent/pom.xml.
| File | Description |
|---|---|
| parent/pom.xml | Updates the shared Bouncy Castle orbit version property used by dependency management and feature bundle definitions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
PR builder started |
|
PR builder completed |
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
left a comment
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/35611334156

Purpose
Move the Bouncy Castle orbit bundles from
1.84.0.wso2v1to1.85.0.wso2v1.Approach
bouncycastle.versioninparent/pom.xmldrives all four bundles shipped by theorg.wso2.carbon.core.serverfeature —bcprov,bcpkix,bctlsandbcpg— so this is asingle-property change.
bcprov,bcpkixandbcpgat1.85.0.wso2v1came from wso2/orbit#1402;the matching
bctlsbundle is wso2/orbit#1412.All four are published and resolve from
wso2-public.