Move viewer stylesheets out of the host modules into .css files - #113
Merged
Frotty merged 2 commits intoSep 5, 2026
Merged
Conversation
The object editor's ~1,380 lines of CSS, the MPQ viewer's and the shared map-data page styles were template literals inside TypeScript host modules, where nothing could lint or format them. They now live as real stylesheets under src/webview/, inlined into the host bundle by a webpack asset/source rule (and by the test loader), with the two runtime values the object editor needs (--wc3-tip-width and the optional tooltip @font-face) injected as a trailing rule. The extracted text is byte-identical to what the template literals produced.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #112. Fourth slice of the audit list: the start of moving webview presentation out of the host TypeScript.
src/webview/objModEditor/objModEditor.css(1,380 lines),src/webview/mpqViewer.cssandsrc/webview/mapData.cssreplace template literals inobjModPreview.ts,mpqViewer.tsandmapDataPreview.ts.asset/sourcerule inlines them into the host bundle;e2e/harness/tsLoader.jsdoes the same for tests, andsrc/types/assets.d.tstypes the imports.--wc3-tip-widthfromwurst.objModTooltipWidth, and the optional tooltip@font-face) are injected as a trailing rule after the stylesheet.objModPreview.tsshrinks from 4,214 to 2,840 lines;mapDataPreview.tsandmpqViewer.tslose their style blocks. The inline webview scripts are the next step and are not part of this PR.Validation
tsc(real siblings and CI mocks),npm run lint,npm test: clean.npm run compile-web: bundles build and contain the inlined CSS.npm run test:e2e: same result set asmasterapart from the two known flaky object-editor specs.