Skip to content

formula: tinyalsa/tinyalsa - #515

Open
MeteorsLiu wants to merge 2 commits into
xgo-dev:mainfrom
MeteorsLiu:issue/239-tinyalsa-luna
Open

formula: tinyalsa/tinyalsa#515
MeteorsLiu wants to merge 2 commits into
xgo-dev:mainfrom
MeteorsLiu:issue/239-tinyalsa-luna

Conversation

@MeteorsLiu

Copy link
Copy Markdown
Collaborator

Adds tinyalsa/tinyalsa as an idiomatic LLAR Formula translated from the pinned Conan Center recipe.

  • Uses exact upstream tags 1.1.1 and v2.0.0, with normalized semver ordering for the complete mixed-prefix tag set.
  • Preserves the Linux-only contract, shared and with_utils output options, source Makefile portability fixes, the v2 warning patch, NOTICE, headers, libraries, utilities, and v2 dl linkage.
  • Publishes relocatable tinyalsa.pc metadata from LLAR’s complete pkg-config cflags-and-libs lookup and tests the Conan consumer plus optional tinymix --help.

Validation covered LLAR 107a2d0ca6ed9524ccf465cf9449a8943afd1d3e on Linux amd64 and arm64: v2.0.0 fresh/default, cache-hit/default, shared, with_utils, combined options, v1.1.1 default/shared/with_utils, and expected rejection below 1.1.1 and on Darwin. Installed artifacts and .pc contents were audited.

Closes #239

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mixed-prefix tag comparator, both pinned upstream build contracts, installed headers/libraries/pkg-config metadata, option behavior, default selection, and cache-hit consumer path are consistent with the requested tinyalsa translation. Focused LLAR tests passed for v2.0.0 default, v2.0.0 shared+utilities, and 1.1.1 shared+utilities; the unsupported 1.1.0 boundary was also rejected as intended.

The current repository validation gate cannot process both Formula threshold directories in one change, so this PR needs to be separated before the normal platform matrix can run.

View job run


id "tinyalsa/tinyalsa"

fromVer "1.1.1"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Split the Formula thresholds so CI can validate them

This diff adds Formula files under both tinyalsa/tinyalsa/1.1.1 and tinyalsa/tinyalsa/v2.0.0, but .github/scripts/find_changed_modules.gsh records each changed Formula directory and unconditionally panics when a module has more than one (llar test cannot validate multiple fromVer ranges yet). Consequently, rerunning the required workflow stops in Find changed modules and none of the Linux/macOS platform tests execute. Please land the module registration, comparator, and v2.0.0 recipe first, then add this 1.1.1 threshold in a follow-up PR (or change the validation gate separately).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Translate Conan Center tinyalsa recipe to LLAR

1 participant