formula: stevengj/nlopt - #516
Conversation
There was a problem hiding this comment.
Reviewed the NLopt formula and module metadata across the complete fixed diff. The package build, generated pkg-config metadata, license installation, consumer test, and registry shape are consistent; the inline finding below concerns the exposed fPIC option for newer upstream versions.
Verification included LLAR builds/tests for v2.8.0 on linux/amd64 with default options and with --option fPIC=OFF, plus direct upstream CMake checks across v2.6.1 and v2.8.0.
|
|
||
| filter => { | ||
| for name, values in target.options { | ||
| if name != "shared" && name != "fPIC" && name != "enable_cxx_routines" { |
There was a problem hiding this comment.
[P1] Do not expose ineffective fPIC=OFF for v2.8+
Because this formula serves every version from v2.6.1 onward, it also handles v2.8.0+, whose upstream CMakeLists.txt unconditionally sets the nlopt target's POSITION_INDEPENDENT_CODE to ON. Consequently, CMAKE_POSITION_INDEPENDENT_CODE=OFF here is ignored for those releases: an explicit --option fPIC=OFF still compiles the static archive with -fPIC. That makes the retained option produce a result different from what callers requested. Please split the formula at v2.8.0 (or otherwise remove/reject this option for that range) so fPIC=OFF is not advertised where upstream cannot honor it.
Summary
stevengj/nloptfrom Conan Center snapshotd034b32b3106d282c32f0a23314b5c6ba1b0fa69.shared,fPIC, andenable_cxx_routinesoptions, disables unused upstream bindings/tests, and carries the recipe licenses.nlopt.pcmetadata and verifies the optimization consumer through the complete pkg-config lookup.Evidence
2.9.1resolves to upstream tagv2.9.1and peeled revision11cff2c773b4b98821915a72179f4667c307ce6d; the recorded archive SHA256 matches.fromVeris the earliest compatible recipe tagv2.6.1; all seven Conan-served tags throughv2.9.1and the current defaultv2.11.0passed on nativedarwin/arm64.shared=ON,fPIC=OFF, andenable_cxx_routines=OFF;v2.6.0is rejected below the floor.Closes #247