formula: Neargye/magic_enum - #520
Conversation
There was a problem hiding this comment.
The v0.9.7 formula and relocatable pkg-config consumer path are consistent with the upstream install contract. One compatibility issue remains in the older threshold: v0.9.4–v0.9.6 need the Conan recipe's header-layout normalization before they can share the v0.9.2 formula.
|
|
||
| // v0.9.2 is the earliest threshold whose source-compatible range remains | ||
| // valid through v0.9.6; v0.9.0 and v0.9.1 fail the C++17 consumer on Clang. | ||
| fromVer "v0.9.2" |
There was a problem hiding this comment.
[P1] Preserve the nested headers for v0.9.4–v0.9.6
This threshold also selects v0.9.4, v0.9.5, and v0.9.6, but those upstream tags changed their source layout to include/magic_enum/*.hpp. Their CMake install rules flatten that directory into include/*.hpp; the Conan recipe explicitly copies the installed headers back into include/magic_enum for exactly these versions. As written, consumers using the documented/newer interface #include <magic_enum/magic_enum.hpp> fail for every 0.9.4–0.9.6 package even though the formula's own test only exercises the legacy top-level include. Add the same compatibility copy for this version interval, or introduce a separate threshold/formula that preserves the nested layout.
Summary:
Validation:
Closes #302