test: repair PSRAL conformance baseline - #39
Merged
Conversation
There was a problem hiding this comment.
Review
This is a data-only baseline update: runtime_verified_forms bumped 34 → 35 for all 8 amd64 entries (go1.20–go1.27) in testdata/coverage/go-asm-baseline.json.
Consistency checks (all pass):
- The bump is applied uniformly to every amd64 entry; other archs (arm64=62, others=0) are correctly untouched.
- Leaving
coverage_fingerprint,supported_forms,unique_forms, andunsupported_formsunchanged is correct:RuntimeVerifiedFormsis incremented independently of the status buckets and the fingerprint (form + statustuples) incmd/plan9asmscan/main.go, so a form flipping to runtime-verified moves only this counter.
One inline finding (stale doc) noted below.
Notes (non-blocking):
- The baseline is a hand-maintained golden file with no automated regeneration/diff test tying it to scanner output (only the conformance manifest is guarded). Consider a golden
-updatemode so future bumps are self-verifying. - Consider naming the specific newly runtime-verified form in the PR description so the
34 → 35change is auditable without re-running the scanner.
No correctness, security, or performance issues found in the diff itself.
Additional findings
doc/plan9asm-corpus.md:227: [P2] Stale runtime-verified count in doc table (still 34): The Go 1.27 snapshot table still lists the amd64 runtime verified column as34, but this PR bumpedruntime_verified_formsto35for go1.27/amd64 intestdata/coverage/go-asm-baseline.json— which this doc explicitly names as the authoritative machine-readable source. Update this cell to35to keep the doc consistent with the baseline.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the main-branch CI regression introduced when PR #35 added executable PSRAL coverage.
The PSRAL form was already present and classified as supported in every Go 1.20–1.27 official amd64 corpus. The new native-Go-vs-LLVM conformance case increases only
runtime_verified_forms, from 34 to 35, for each supported Go version. PR #35 was merged while its post-push corpus jobs were still running, so the missing baseline update reached main and all stdlib-corpus jobs subsequently failed.Validation:
scripts/check-go-asm-coverage.sh(Go 1.27 locally)This intentionally contains only the baseline repair; the external-library corpus and LLVM 22 migration remain in PR #38.