Skip to content

test: repair PSRAL conformance baseline - #39

Merged
cpunion merged 1 commit into
xgo-dev:mainfrom
cpunion:codex/psral-baseline-20260913
Sep 13, 2026
Merged

test: repair PSRAL conformance baseline#39
cpunion merged 1 commit into
xgo-dev:mainfrom
cpunion:codex/psral-baseline-20260913

Conversation

@cpunion

@cpunion cpunion commented Sep 13, 2026

Copy link
Copy Markdown
Collaborator

Fix the main-branch CI regression introduced when PR #35 added executable PSRAL coverage.

The PSRAL form was already present and classified as supported in every Go 1.20–1.27 official amd64 corpus. The new native-Go-vs-LLVM conformance case increases only runtime_verified_forms, from 34 to 35, for each supported Go version. PR #35 was merged while its post-push corpus jobs were still running, so the missing baseline update reached main and all stdlib-corpus jobs subsequently failed.

Validation:

  • scripts/check-go-asm-coverage.sh (Go 1.27 locally)
  • the PR matrix validates the same baseline against Go 1.20–1.27

This intentionally contains only the baseline repair; the external-library corpus and LLVM 22 migration remain in PR #38.

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

This is a data-only baseline update: runtime_verified_forms bumped 34 → 35 for all 8 amd64 entries (go1.20–go1.27) in testdata/coverage/go-asm-baseline.json.

Consistency checks (all pass):

  • The bump is applied uniformly to every amd64 entry; other archs (arm64=62, others=0) are correctly untouched.
  • Leaving coverage_fingerprint, supported_forms, unique_forms, and unsupported_forms unchanged is correct: RuntimeVerifiedForms is incremented independently of the status buckets and the fingerprint (form + status tuples) in cmd/plan9asmscan/main.go, so a form flipping to runtime-verified moves only this counter.

One inline finding (stale doc) noted below.

Notes (non-blocking):

  • The baseline is a hand-maintained golden file with no automated regeneration/diff test tying it to scanner output (only the conformance manifest is guarded). Consider a golden -update mode so future bumps are self-verifying.
  • Consider naming the specific newly runtime-verified form in the PR description so the 34 → 35 change is auditable without re-running the scanner.

No correctness, security, or performance issues found in the diff itself.

Additional findings

  • doc/plan9asm-corpus.md:227: [P2] Stale runtime-verified count in doc table (still 34): The Go 1.27 snapshot table still lists the amd64 runtime verified column as 34, but this PR bumped runtime_verified_forms to 35 for go1.27/amd64 in testdata/coverage/go-asm-baseline.json — which this doc explicitly names as the authoritative machine-readable source. Update this cell to 35 to keep the doc consistent with the baseline.

@codecov

codecov Bot commented Sep 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@cpunion
cpunion merged commit cc0ad3c into xgo-dev:main Sep 13, 2026
60 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant