Repository navigation
RigShare 1.3.1: refuse folder paths outside the workspace - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue raised on the ComfyUI-Manager listing (Comfy-Org/ComfyUI-Manager#3344): folder routes built paths from request values, so on Windows a drive prefix could escape the workflows folder.
safe_join()refuses colon/..segments and requires the realpath to stay under the workflows root; used by every folder route and the listingPython suite (excluding test_server.py, which hangs locally with or without this change) and JS tests pass.