Skip to content

RigShare 1.3.3: proxy trust, login throttling, cross-site and framing protection - #3

Merged
xiaodoudou merged 6 commits into
masterfrom
security-hardening-2
Oct 8, 2026
Merged

xiaodoudou merged 6 commits into
masterfrom
security-hardening-2

Conversation

@xiaodoudou

@xiaodoudou xiaodoudou commented Oct 8, 2026 •

Copy link
Copy Markdown
Owner

On top of #2. It retargets to master once #2 is merged.

Four fixes, mostly for servers behind a reverse proxy:

  • Login could be bypassed. A proxy on the same machine made every visitor look like 127.0.0.1, which is trusted by default, so the login check never applied to them. Trust now follows the visitor's own address (the last X-Forwarded-For / X-Real-IP entry), and login is required again.
  • Failed logins are limited per address and per account, answered with Retry-After, and logged. Old entries are dropped.
  • Writes and the websocket are refused when they carry the session cookie and the Origin hostname doesn't match the Host.
  • The login page sends headers that stop other sites from framing it.

@xiaodoudou
xiaodoudou changed the base branch from access-hardening to master October 8, 2026 11:29
@xiaodoudou
xiaodoudou merged commit 3de3cc3 into master Oct 8, 2026
2 checks passed
@xiaodoudou
xiaodoudou deleted the security-hardening-2 branch October 8, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant