Add ReplayGain handling modes and automatic filenames to opusenc - #109
Open
JaoDoSantoCristo wants to merge 7 commits into
Open
Add ReplayGain handling modes and automatic filenames to opusenc#109JaoDoSantoCristo wants to merge 7 commits into
JaoDoSantoCristo wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a --replaygain-mode argument that allows tweaking the handling of RG tags:
0 will completely scrap all ReplayGain tags;
1 will convert it to the EBU R128 standard, and yes it does account for the target difference;
2 just copies the values directly, not ideal but some players don't know what an "Arr One Twenty-Eight" is;
3 puts the track gain directly in the header and does some stuff to correct for the volume difference in players that DO support R128, since the decoder handles header gain this works on everything.
Also added automatic output filenames, to speed up conversion:
It strips the path and replaces the extension, pretty simple. The option of typing it manually is still there if needed.