Skip to content

A potential bug of NPD related to usage of libogg #37

Open
Open
A potential bug of NPD related to usage of libogg#37

Description

@ash1852
ash1852
opened on Sep 13, 2022

Hi, I found a potential null pointer dereference bug in the project source code of opusfile related to usage of libogg, and I have shown the execution sequence of the program that may generate the bug on the graph below. The red text illustrates the steps that generate the bug, the red arrows represent the control flow.
os_lacing_expand
in short, the key step is not check the return value of call-statement relate to libogg.

opusfile/src/opusfile.c

Lines 2240 to 2246 in a46042a

static void op_buffer_continued_data(OggOpusFile *_of,ogg_page *_og){
ogg_packet op;
ogg_stream_pagein(&_of->os,_og);
/*Drain any packets that did end on this page (and ignore holes).
We only care about the continued packet data.*/
while(ogg_stream_packetout(&_of->os,&op));
}

would you help to check if this bug is true?thank you for your patience and effort.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions