Repository navigation
Bump the vendored engine to eddf187c, engine master - #265
Merged
Merged
Conversation
The engine's lang-symbols.tsv lands with this pin, so the build_strings.sh switch becomes possible in a later change. The 33 engine commits add and remove no source, so Android.mk's explicit list is unchanged. HTTRACK_VERSIONID is still 3.50.5, so versionName stays as it is. The nested coucal pointer moves with it. hts_bundle_from_paste is still exported and now forwards to a new hts_bundle_from_paste_flags, which holds the body. So htslibjni.c is untouched, and the test that pins the write ordering follows the body into that function. That test's guard was also a weak needle. Inverting the engine's `if (!` on the read-back left it green, because the search walked back to an earlier `if (!`. Both now read as one string, and four mutants of the engine source turn the test red. Signed-off-by: Xavier Roche <xroche@gmail.com> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Two mutants of the engine source survived the test: replacing the guard's PASTE_FAIL with a success, and making it conditional. Both leave a bundle the read-back rejected in the project folder, which is the property the test claims. The guard and its whole statement now read as one regex, and the write has to come after that statement rather than after the call. The test also never checked that the JNI calls the entry point it inspects. Switching htslibjni.c to the flags call left it reading an unrelated wrapper, so it asserts that call now. Seven mutants of the engine source turn it red, and reflowing the guard across lines does not. Signed-off-by: Xavier Roche <xroche@gmail.com> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine's
lang-symbols.tsvlands with this pin, so thebuild_strings.shswitch becomes possible in a later change. No engine source was added or removed over the 33 commits, soAndroid.mk's list is unchanged.HTTRACK_VERSIONIDis still 3.50.5, soversionNamestays as it is.hts_bundle_from_pasteis still exported and now forwards to a newhts_bundle_from_paste_flags, which holds the body. The test that pins the write ordering follows the body into that function. It now pins the read-back guard's own statement, because two mutants that left a rejected bundle in the folder passed the old shape.