Repository navigation
Move the browser-login button to the wizard's first page - #280
Merged
Merged
Conversation
The button sat inside the Add URL dialog, where people did not find it. It now has its own row under the address box. The login starts from the address under the caret, or else the first address in the box, and the landed address replaces that one. Before, Add URL appended the landed address, so the typed one stayed as a second root. With no address in the box, the landed one is appended. The pick is a pure helper, browserLoginPickAddress(), covered by nine new selftest cases (71 -> 80, pinned in all four places). The screenshot walk now checks the button on the URL pane and its absence from Add URL. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
xroche
marked this pull request as draft
November 3, 2026 19:53
Review of #280 found two defects: - The address picker split only on space, tab, CR and LF, while the engine's hts_scan_token() also splits on form feed and vertical tab. With "a.test\vb.test" the browser opened a.test and the splice then deleted b.test. The picker now walks hts_scan_token() itself. - The login window disabled only the wizard page, so Next, Finish and the menu stayed live while it was open. It now owns the top-level window, as the modal Add URL dialog did. The splice moves into browserLoginSplice(), so its "own line" rule has one owner and selftest rows. New rows also pin a caret at a word's start, a caret between two blanks, and each trailing blank byte; every one kills a mutant that survived the old table (80 -> 91 checks). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
hts_scan_token() copies a token's raw bytes, so the word ends at its start plus strlen(token). The local copy of HTS_REALSPACES and the trim loop changed no outcome, so they go. A splice that dropped everything after the replaced address passed every row, because each row replaced the last word. The new row replaces the first one (91 -> 92 checks). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
The walk waited for a window titled "Accept headers", so every walk in another language timed out there. It now looks for the new top-level window holding IDC_accept_default, as insert_url_box() already does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
xroche
marked this pull request as ready for review
November 3, 2026 20:33
xroche
enabled auto-merge (squash)
November 3, 2026 20:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The browser-login button was hidden inside the Add URL dialog. It now has its own row under the address box on the first page.
The address the browser ends on now replaces the one the login started from. That is the address under the caret, or else the first one. Add URL appended it instead, so the typed address stayed as a second start URL. The screenshots and the docs still show the old place, so the next release needs both redone.
The screenshot walk now finds the Accept headers box without its English title, so a translated walk no longer times out there.