Repository navigation
Keep the cookies of every site a browser login went through - #281
Merged
Merged
Conversation
The login window now reports each page it loaded, redirects included, and the GUI passes their hosts to the engine's new hts_bundle_from_paste_hosts(). A login that signs in on another site, such as a single sign-on service, now keeps that site's cookies in the bundle. The DLL interface goes to version 4, because the request grows an onPage callback. Cookies the engine leaves out are added to the count the user is told about. Needs engine 483d5d47 or later. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B4P6j1Y145icu4vPHeRjJc Signed-off-by: Xavier Roche <roche@httrack.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B4P6j1Y145icu4vPHeRjJc Signed-off-by: Xavier Roche <roche@httrack.com>
The window now records a site when a redirect hop leaves it or when its page completes, rather than when a navigation starts. The profile lasts for the whole program run, so a site that never answered could still hand over cookies an earlier login left there. The DLL also keeps only the scheme and host of each page, which keeps sign-in tokens out of memory and bounds the list. Static checks now pin the three lines that carry the sites to the engine. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B4P6j1Y145icu4vPHeRjJc Signed-off-by: Xavier Roche <roche@httrack.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B4P6j1Y145icu4vPHeRjJc Signed-off-by: Xavier Roche <roche@httrack.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A browser login that signs in through another site, such as a single sign-on service, now keeps that site's cookies too. The login window reports every site that answered it, redirects included. The GUI passes their hosts to the engine's new
hts_bundle_from_paste_hosts(), so this needs engine 483d5d47 or later.The DLL interface goes to version 4, so an old
WhttBrowserLogin.dllbeside the new program is refused rather than misread. The only workflow change is the selftest count, which goes from 92 to 100.