Repository navigation
Conversation
Nothing writes url_adr or url_fil in the WebHTTrack stats rows, yet the progress panel published both, so strdup() read uninitialised stack on every refresh. Drop the two keys and the dead url_adr, url_fil, offset and actived fields, which also shrinks each stats array by 56 KiB. Do not restore the writes instead: url_adr carries the login that #2000 hides from the panel. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
The positive control now counts any non-empty /trickle/ save path as a live row, so a row still on a name such as p3.bin.4.delayed no longer runs the loop to its deadline. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WebHTTrack progress panel no longer publishes
info.url_adrandinfo.url_fil, and four dead fields leavet_StatsBuffer. No code wrote those two fields, sostrdup()read uninitialised stack on each refresh. Do not write the fields instead, becauseurl_adrcarries the login that #2000 hides from the panel.The new test 746 passes with this change and fails on
origin/masterbuilt with-ftrivial-auto-var-init=pattern, where the keys print0xFEbytes. A default build zero-fills the stack, so the test passes on both trees there.