Repository navigation
Conversation
The WHATWG prescan treats SPACE, TAB, CR, LF and FF as whitespace. is_html_space() left FF out, so <meta\fcharset=latin1> found no charset, and an FF after an unquoted http-equiv value merged it with the next attribute, which leaked the closing quote into the charset name. VT is still not whitespace there. Test 01_engine-charset pinned the old set as a side effect of #1516's rename; its two FF rows flip and new FF and VT rows are added. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
A mutant that drops FF from is_html_space_or_equal alone passed the test before these rows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
xroche
enabled auto-merge (squash)
November 7, 2026 18:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
<meta>charset prescan now treats a form feed as whitespace, as the WHATWG prescan does. So<meta\fcharset=windows-1251>is read, and an FF after an unquotedhttp-equivvalue no longer leaks a closing quote into the charset. A vertical tab is still not whitespace, and the MIME sniffer keeps its own set.Test 01_engine-charset asserted the old set only because #1516 pinned it during a rename. Its two FF rows flip, and the new FF and VT rows fail on master. A crawl of a page with that FF meta saves the link as
да.html, where master savesäà.html.tools/parser-diff.shagainst master shows no difference on any leg.