Repository navigation
Conversation
--clean left hts-cache/readme.txt behind on every mirror, so the final rmdir of hts-cache always failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
Share one purge_ref_dir with the end-of-mirror cleanup. It skips a symlinked ref and unlinks only regular files, so it cannot reach cookies.txt or winprofile.ini. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
xroche
enabled auto-merge (squash)
November 7, 2026 19:04
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
xroche
disabled auto-merge
November 7, 2026 19:46
unlink() never follows the last path component, so a symlinked entry only loses the link. The lstat guarded nothing and was the check half of the CodeQL cpp/toctou-race-condition alert 332. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
xroche
enabled auto-merge (squash)
November 7, 2026 19:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--cleannow also removeshts-cache/readme.txt,hts-cache/repair.zipand thehts-cache/ref/directory. Before,readme.txtstayed behind on every mirror, so the finalRMDIRofhts-cachealways failed.cookies.txtandhts-cache/winprofile.iniare still kept on purpose (user state), so a mirror that has them keepshts-cache.New test 766 fails on the master binary (the three names remain) and passes here. A control keeps
cookies.txtandwinprofile.ini. The full suite passes (0 failures). The--helptext and man page are unchanged.