Repository navigation
Conversation
When a resume Range gets a 412 or 416, the partial is dropped and the file is queued again without a Range. That copy set its precedent to the file's own heap slot, so the re-get sent the file itself as Referer. The other two re-record sites already copy heap(ptr)->precedent. Test 20 now logs Range and Referer per request and checks the re-get carries the parent page. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
xroche
enabled auto-merge (squash)
November 7, 2026 18:30
xroche
disabled auto-merge
November 7, 2026 19:46
Windows Python wrote CRLF, so the Referer match in test 20 failed under WSL2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
xroche
enabled auto-merge (squash)
November 7, 2026 19:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A resumed download that gets a 412 or 416 is fetched again from the start. That new request now sends the page that linked to the file as its
Referer, as the first request did. Before, it named the file itself, which a server that blocks hotlinks can refuse. The other two places that queue a file again already copy the parent this way.Test 20 now logs each request to the file and checks the
Refererof the full fetch. It fails on master, where the header is.../resume/blob.txt, and passes with the fix.