Repository navigation
Conversation
Drop the dashvalue_opt allowlist: every option that takes a value now takes a word starting with '-' unless that word names an option. The htscoremain.c guards, the -O cluster step and the lone -N real form accept a marked parameter the same way. Clustered spellings (-qP -x) still refuse, since nothing vets them. Numeric options now reach their own value check, so --warc-max-size=-5 says it needs a non-negative number. Tests 363, 565, 733 and the optalias self-test follow the new rule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
A short option glued to its number or to one more option (-r6, -c8, -qO, -#test) now names an option, so `-O -r6` fails rather than mirroring into a folder named -r6. A longer word (-archive, -my%n) is still taken as a value. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
Signed-off-by: Xavier Roche <roche@httrack.com>
The -F, -%A, -%g, -%C, -%F, -%K, -%L, -%S, -%rf, -%X and --bundle-dir options accepted a glued value such as `--user-agent -Oz` on master. The previous commit refused it. Those options now skip the glued-option check, and test 564 is back to `--user-agent -Oz`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
xroche
enabled auto-merge (squash)
November 7, 2026 19:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every option that takes a text value now accepts a value starting with
-, as--user-agent -xalready did. A word that names an option is still refused. So is a short option glued to its number or to one more, like-O -r6or-P -qO. The options that always took such a value (-F,--assumeand the rest ofdashvalue_opt) still take it, so--user-agent -Ozworks. A longer word such as-archiveis taken as a value, and numeric options reject-5with their own value check.Tests 363, 564, 565 and 733 and the
optaliasself-test follow the new rule. The new 363 and 733 cases fail on the master binary, and a mutant that stops recognizing glued options fails 363 at-O -r6.